Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibnet Watermelon fix + mainnet watermelon upgrade #3674

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Nov 6, 2023

Summary of changes

Changes introduced in this pull request:

  • update the mainnet schedule with a fixed watermelon bundle,
  • added post-migration verifications. Technically, we could re-use post migrators, but a non-mut version seems more expressive,
  • apply the calibnet patch at the agreed height (https://github.com/filecoin-project/lotus/releases/tag/v1.24.0-rc4),
  • update manifests,
  • update the devnet to use the new, shiny watermelon with the new Lotus (needed because the bundles were updated),
  • No tests, given it's calibration network only, and I can't check it with devnet without a bunch of tinkering and patching Lotus. The only thing I came up with was a manual upgrade test at a different height - the migration passes, the sanity checks pass, and then there's a state mismatch from chain muxer (as expected).

Reference issue to close (if applicable)

Closes #3632

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the watermelon-fix branch 4 times, most recently from 287399d to 31e8057 Compare November 6, 2023 13:56
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review November 6, 2023 14:39
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner November 6, 2023 14:39
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and jdjaustin and removed request for a team November 6, 2023 14:39
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit e2ee077 Nov 6, 2023
30 checks passed
@LesnyRumcajs LesnyRumcajs deleted the watermelon-fix branch November 6, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NV21 watermelon fix for calibnet
3 participants