Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't create test artefacts in repo root #3626

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

LesnyRumcajs
Copy link
Member

Summary of changes

Changes introduced in this pull request:

  • more checks for actors bundle,
  • don't create test artefacts in the repo root (without this change, each invocation of make test would create actor_bundles.car.zst in the root, making the directory dirty)

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner October 24, 2023 10:32
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and aatifsyed and removed request for a team October 24, 2023 10:32
@lemmih lemmih added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit b922d7a Oct 25, 2023
24 checks passed
@lemmih lemmih deleted the no-test-artifacts-in-root branch October 25, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants