Fix: Don't duplicate buffer views that are referenced multiple times. #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this fix @freezy, I'll try to review later this week. Can you send over a CLA if you haven't already? |
|
Oh, sorry I didn't know there was a CLA to sign. In this case I prefer maintaining my own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reference to each processed view buffer and doesn't re-add it when matched. It avoids resources being duplicated. This PR fixes #416.
The map is stored in the root's pipeline extras. It's an object, since I wasn't sure if using
Mapwouldn't introduce any issues with old browsers.Note that this doesn't apply to buffer views who share the same segment in a buffer, those would still be duplicated.