Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 20 & 18 #11598

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Update to Node 20 & 18 #11598

merged 2 commits into from
Oct 31, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Oct 30, 2023

Updates CI to use Node 20 and Node 18 instead of Node 18 and Node 16 respectively.

Also update a few dev dependencies in preparation for the release. They support CI deployment and screenshot testing with playwright.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ggetz !

@jjhembd jjhembd merged commit 397f0b6 into main Oct 31, 2023
@jjhembd jjhembd deleted the node-updates branch October 31, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants