Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pinned "zip.js" version in package.json #10712

Closed
ggetz opened this issue Aug 22, 2022 · 5 comments · Fixed by #11804
Closed

Remove pinned "zip.js" version in package.json #10712

ggetz opened this issue Aug 22, 2022 · 5 comments · Fixed by #11804
Labels
cleanup

Comments

@ggetz
Copy link
Contributor

ggetz commented Aug 22, 2022

#10694 pinned zip.js to 2.4 in order to fix #10684 based on this recommendation by the zip.js maintainer. Once the package no longer uses TransformStream, this workaround should be removed.
@ggetz ggetz added the cleanup label Aug 22, 2022
@ggetz ggetz mentioned this issue Aug 22, 2022
Closed
@jjhembd jjhembd changed the title Removed pinned "zip.js" version in package.json Remove pinned "zip.js" version in package.json Aug 23, 2022
@ggetz ggetz mentioned this issue Jan 12, 2023
Closed
@ggetz ggetz mentioned this issue Sep 20, 2023
Closed
@ggetz
Copy link
Contributor Author

ggetz commented Sep 20, 2023

An issue with the pinned version of zip reported in #11526.

@ramtob
Copy link

ramtob commented Oct 4, 2023

@ggetz
Hi. Is there some working plan when this issue will be dealt with?

@jjhembd
Copy link
Contributor

jjhembd commented Jan 31, 2024

Since #11598, we have updated the minimum Node version to 18, which now supports TransformStream. With Node 18 or higher installed, the test in #10684 runs through without error.

I think we can update zip now. @ggetz or @mramato am I missing anything?

@mramato
Copy link
Contributor

mramato commented Jan 31, 2024

@jjhembd No, that sounds reasonable to me.

@ggetz
Copy link
Contributor Author

ggetz commented Jan 31, 2024

Sounds good to me @jjhembd.

@jjhembd jjhembd mentioned this issue Jan 31, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

February npm updates CesiumGS/cesium
4 participants
@mramato @ggetz @ramtob @jjhembd