Spec updates for new bounding volumes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready. Any feedback? |
| "properties" : { | ||
| "box" : { | ||
| "type" : "array", | ||
| "description" : "An array of 12 numbers that define a oriented bounding box in WGS84 coordinates. The first three elements define the x, y, and z values for the center of the box. The next three elements (with indices 3, 4, and 5) define the x axis direction and length. The next three elements (indices 6, 7, and 8) define the y axis direction and length. The last three elements (indices 9, 10, and 11) define the z axis direction and length.", |
There was a problem hiding this comment.
Not quite sure I understand this. The first three numbers is the center vector, and the following groups of three numbers are vectors that specify lengths and directions of the box's sides, is that right? Does axis here refer to the box's own 'axes'?
There was a problem hiding this comment.
Yes and yes. This is a standard OBB representation.
|
Everything else looks clear. |
|
I made some small edits. Looks good to me. |
lilleyse
added a commit
that referenced
this pull request
Dec 18, 2015
Spec updates for new bounding volumes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48 and #10
We'll consider AABB and k-DOPs (both originally discussed in #10) if/when needed.
Cesium implementation: CesiumGS/cesium#3325
@e-andersson and @lilleyse please review.