-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different bounding volumes #10
Comments
+1 |
Until we flush out the bounding volume, Cesium is deriving the bounding sphere from the bounding box: https://github.com/AnalyticalGraphicsInc/cesium/pull/3158/files#diff-e51181d6e2f4fd006b1404f2fe1f65a2R58 Not optimal, but only temporary. |
I'm not ready to fully design this quite yet, but I am thinking we will replace
I think There may also be a need for box to be an OBB (or for separate AABB and OBB properties). Perhaps the spec will allow multiple bounding volumes to be declared in Is allowing multiple bounding volumes overkill, e.g., the union of children bounding volumes is a better fit than a parent's bounding volume so it can be useful to test the parent, then children bounding volumes before rendering the parent. This can be done with the current tiles.json schema. Is something more general worth the complexity? |
Is there anything I can do to help on this? I think we'd like to use a bounding sphere for the root tile in a global tileset scenario, so we can have a root covering the whole globe. |
Yes, you are welcome to do all of it. 👍 In Cesium, here are the types of interest: I have also toyed with the idea that we only need AABB, not OBB, since the tileset should be able to define a local coordinate system, e.g., for point clouds or cities that are not subdivided on longitude/latitude boundaries, so the tiles would use an AABB in the tileset's coordinate system, which would be an OBB in WGS84. I dunno, it will need some implementation work to be sure. To get started, perhaps you could just do the least amount needed to the spec and Cesium to add support for bounding spheres. Then we can see how to scale it to AABB/OBB (should be obvious). What do you think? |
That's generous 😄 Sounds good, I'll have a go at adding support for bounding spheres and then we'll see about the other types. |
Awesome! Looking forward to you progress. |
Spec updates: #51 |
Point clouds use
contents.boundingSphere
for the RTC center point. This is not documented yet in README.md. We could put it in the tile itself, but it belongs here instead if 3D Tiles allow bounding spheres as a potential bounding volume, which I suspect we will.The text was updated successfully, but these errors were encountered: