Expect the protected key to always exist
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid having to determine the user's role to infer whether a branch is protected or not.
Shahaed
approved these changes
Sep 28, 2022
Shahaed
approved these changes
Sep 28, 2022
| @@ -188,17 +187,14 @@ def protected_branch(branch: str) -> str: | |||
| """ | |||
| url = f"/repos/{os.getenv('GITHUB_REPOSITORY', '')}/branches/{branch}" | |||
| response: "Dict[str, Any]" = api_request(url) # type: ignore[assignment] | |||
| if response.get("protected", False): | |||
| if check_user_role("admin"): | |||
There was a problem hiding this comment.
This should work. I only removed this line and this action worked with the Github App token.
Then I found out docker actions don't run on macos runners where I needed this action to do our iOS builds. So I had to rewrite this entire action in javascript 🙃. FML, but I used this action as a guide so it was fairly smooth. Thanks!
There was a problem hiding this comment.
I have wanted to do this for a while; updating it to JS from Docker. If you want to contribute it back feel free, otherwise it's fair to release under a fork as a new action as well 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144
This is to avoid having to determine the user's role to infer whether a branch is protected or not.