You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A token from a Github App can have the same permissions as an admin PAT and is probably more appropriate to use than a PAT. (Github App tokens can be gotten this way: https://github.com/tibdex/github-app-token).
This action currently doesn't support tokens from a Github App (even with the correct permissions) because this line:
checks for the admin property in the permission object in the response which a Github App can't have be true.
I think the easiest way to do this would be by removing the admin check and if someone is using a token with insufficient permissions, fail at that specific api.
The text was updated successfully, but these errors were encountered:
@Shahaed do you have a possibility to test out the currently open PR? It can be tested by changing the version of the action to instead point to cwa/close-144-allow-app-tokens:
A token from a Github App can have the same permissions as an admin PAT and is probably more appropriate to use than a PAT. (Github App tokens can be gotten this way: https://github.com/tibdex/github-app-token).
This action currently doesn't support tokens from a Github App (even with the correct permissions) because this line:
push-protected/push_action/utils.py
Line 292 in 035cda7
checks for the
admin
property in thepermission
object in the response which a Github App can't have be true.I think the easiest way to do this would be by removing the admin check and if someone is using a token with insufficient permissions, fail at that specific api.
The text was updated successfully, but these errors were encountered: