Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux support #114

Closed
wants to merge 1 commit into from
Closed

Linux support #114

wants to merge 1 commit into from

Conversation

rahul0x24
Copy link
Contributor

@rahul0x24 rahul0x24 commented Apr 13, 2019

@ikesyo - #110 broke the build on Linux so I added macOS conformance and a step in CI.

Tests/LinuxMain.swift Outdated Show resolved Hide resolved
Sources/Task.swift Outdated Show resolved Hide resolved
Sources/Task.swift Outdated Show resolved Hide resolved
Sources/Availability.swift Outdated Show resolved Hide resolved
Sources/Task.swift Outdated Show resolved Hide resolved
Sources/Task.swift Outdated Show resolved Hide resolved
Tests/LinuxMain.swift Outdated Show resolved Hide resolved

Quick.QCKMain([
StringExtensionSpec.self,
TaskSpec.self,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)

@rahul0x24 rahul0x24 force-pushed the linux-support branch 2 times, most recently from 3c72c33 to 9ded1c7 Compare April 13, 2019 10:37
@ikesyo
Copy link
Member

ikesyo commented Apr 13, 2019

#110 broke the build on Linux

FYI until Swift 5.0 there had been unimplemented Process APIs in swift-corelibs-foundation, so Linux was not actually supportred (swiftlang/swift-corelibs-foundation#1578 implemented those).

@rahul0x24
Copy link
Contributor Author

rahul0x24 commented Apr 13, 2019

@ikesyo - Thanks for the reply. I was wondering why the tests are failing.

One of my Kitura Project has a dependency on Swift package AarKay which has a library that depends on ReactiveTask. Even though the Kitura project uses the other library from AarKay and not the one that depends on ReactiveTask, It still fails to deploy the application because SPM fetches all the packages and checks all targets for compatibility.

For this reason, I had submitted the PR before also - #109 and I was able to deploy it on the server. It's strange but let me see if I can work around SPM by breaking the project in different repositories altogether.

If Swift 5.0 has the support of Process APIs, I will try to rerun the tests after this library is updated.

@rahul0x24 rahul0x24 closed this Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants