Use the NSConcreteTask.setStartsNewProcessGroup private API to terminate subprocesses when the parent process exits
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inate subprocesses when the parent process exits
mdiep
approved these changes
Sep 13, 2018
|
Ugh. I hate using private APIs. But this seems like it's probably worth it. |
|
Thanks @mdiep. I'm not a fan of this too, but it should work nicely. However, it occurs to me that this might not be ideal in some cases, so I'll add a parameter to the |
|
Just updated: 9143189, which should preserve the backward compatibility. |
mdiep
approved these changes
Sep 27, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #3. I'm not sure how to correctly test this but this passes the test suites at least.