Ports Tweaks #82

ArcLumin · 2017-01-23T18:44:50Z

🆑 Tweaks
tweak: Added lots of the minor tweaks from hippie to the rebase code.
/:cl:

updates

KayeArray · 2017-01-23T18:48:31Z

do it

ArcLumin · 2017-01-23T18:53:01Z

This is like 30 PR's worth of stuff

KittyKathy · 2017-01-31T16:00:12Z

For the E.X.P.E.R.I-MENTOR code.

When it actually makes the cloud of smoke with chemicals it's only 1 tile of smoke which is the tile the machine is on so it does not really affect anyone near the machine maybe make the smoke cloud a bit bigger?
When it creates the Cup of Suspicious Liquid it removes 25 reagents from the cup which is usually coffee then it tries to add 50 units of whatever it plans to add to the cup. The problem is the cups start with 30 units of coffee so instead of 50 units of whatever chemical it wants to give, you get like 5 units coffee and 45 units of whatever it gives you.

For the Reviver implant

It used heal you when you were unconscious does this mean that when you were hurt but not in critical condition you could use the sleep command to heal yourself?
It probably sucked before because when you were in crit you were technically not unconscious until you hit deep crit in which it healed you back to consciousness but effectively you will be in a infinite crit unless you sleep or bleed out and die.
Woah look at those tech levels this is what it is on the rebase origin_tech = "materials=5;programming=4;biotech=4" this is what it is on hippie code origin_tech = "materials=6;programming=3;biotech=6;syndicate=4" where are my easy syndicate tech levels at? Are all the origin tech levels changed in the rebase? do we keep the tg levels or revert the levels to hippie levels?

I looked over the changes they are good.

ArcLumin · 2017-01-31T16:08:11Z

So, lemme respond;

for EXPERIMENTOR

The smoke call is for the relics, i.e. the corgi spawning relic. It creates a cloud of smoke where the corgi appears, and only that tile. It's not used on the experimentor itself.
Yeah, it's a fuckup with the experimentor code I left in, because it's funny. There's also a fuckup where instead of one of them creating a cup of coffee it makes them a fucking coffee MACHINE. Experimentor code is fucky and hilarious

For Reviver

Yeah, you could use the sleep command to heal yourself VERY SHITTILY with the reviver. And no, it healed so poorly before you wouldn't be able to infinitely be critted
Yeah, /tg/ nerfed tech levels, let me boost that back up

j-mie · 2017-01-31T20:47:57Z

code/game/objects/items/weapons/storage/backpack.dm

-	max_combined_w_class = 15
+	w_class = 2 //Can fit in your ass.
+	max_combined_w_class = 20
+	embed_chance = 1 //This is a meme


No. Don't do this.

This is already in hippiecode

j-mie · 2017-01-31T20:54:29Z

code/modules/mob/living/simple_animal/hostile/headcrab.dm

 			Infect(target)
 			src << "<span class='userdanger'>With our egg laid, our death approaches rapidly...</span>"
 			spawn(100)
+				egg_lain = 0


Why are you saying there is no egg when you kill the crab, surely the egg disappears when it's released? https://github.com/ArcLumin/Hippie-Rebase/blob/cf0d69d310e218d4c242bc900decdbdffe85c677/code/modules/mob/living/simple_animal/hostile/headcrab.dm#L74 - if so, perhaps you should set egg_lain in the referenced code?

The idea is, normally if a headslug plants an egg in something, then someone gibs the body, they can't return. This allows a fellow ling to potentially revive the headslug with a lazarus injector and have them plant the egg again. If it didn't set the egg_lain to 0 it'd be unable to plant a new one on respawn. Get it?

Makes sense. :)

Carbonhell · 2017-01-31T20:45:08Z

code/modules/reagents/chemistry/reagents/other_reagents.dm

@@ -171,6 +171,8 @@
 	if(!data) data = 1
 	data++
 	M.jitteriness = max(M.jitteriness-5,0)
+	if(is_vampire(M))
+		M.adjustFireLoss(8) //Holy water kills vampires FAST.


er, vampires aren't in

(nor they're needed tbh,they were horribly coded)

Fair enough, I'll remove this

Carbonhell · 2017-01-31T20:46:50Z

code/modules/reagents/reagent_containers/bottle.dm

+	name = "wasting toxin bottle"
+	desc = "A small bottle. Contains wasting toxin."
+	icon_state = "bottle16"
+	list_reagents = list("wasting_toxin" = 30)


no wasting toxin ingame

Didn't it get ported in the chem PRs?

Carbonhell · 2017-01-31T20:56:24Z