Skip to content

Commit

Permalink
address Oliver's feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
laura-barluzzi authored and amplifi committed Sep 5, 2017
1 parent 8995a3f commit 855df28
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions cadasta/organization/views/default.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,13 +292,14 @@ class OrganizationMembersRemove(mixins.OrganizationMixin,
permission_denied_message = error_messages.ORG_USERS_REMOVE

def admin_is_deleting_themselves(self):
organization = Organization.objects.get(slug=self.kwargs['slug'])
member_to_remove = self.kwargs['username']
user = self.request.user.username
if user != member_to_remove:
return False
user_is_admin = OrganizationRole.objects.get(
organization=organization,
organization__slug=self.kwargs['slug'],
user=self.request.user).admin
return user_is_admin and user == member_to_remove
return user_is_admin

def get_object(self):
return OrganizationRole.objects.get(
Expand All @@ -319,9 +320,7 @@ def delete(self, *args, **kwargs):
if self.admin_is_deleting_themselves():
messages.add_message(self.request, messages.ERROR,
_("Administrators cannot remove themselves."))
return redirect('organization:members_edit',
slug=self.kwargs['slug'],
username=self.kwargs['username'])
return redirect('organization:members_edit', **self.kwargs)
return super().delete(*args, **kwargs)


Expand Down

0 comments on commit 855df28

Please sign in to comment.