feat: slim application state UI to non-handler users #2951
Conversation
aatkin
changed the title
| (when callback | ||
| (callback))))) |
There was a problem hiding this comment.
this allows bootstrap element to communicate state back to reagent component so that UI can render "hidden/show" elements in correct order
There was a problem hiding this comment.
We may also want to consider a new implementation of the collapsible with Bootstrap 5 or so. Maybe CSS animations + React implementation is better.
src/cljs/rems/application.cljs
Outdated
| (defn- application-state [application config highlight-request-id] | ||
| (defn- render-state-fields [application config events] |
There was a problem hiding this comment.
I kind of preferred the older naming convention of application-state component instead of a "render function". Would application-state-details communicate that this is the details that we have initially hidden? Same logic for the others.
| (when-not (false? bottom-less-button?) show-less)]) | ||
| content-footer])) | ||
| (defn- block [{:keys [open?]}] | ||
| (let [show? (r/atom open?)] ; track internal open/closed status |
There was a problem hiding this comment.
This kind of duplicates what was previously handled by the classes/ids. Would be good to refactor this into the atom completely (with CSS animation for opening/closing). Doesn't have to happen now, but we can make sure we have an issue for it.
There was a problem hiding this comment.
yeah, currently bootstrap is handling the animation. i'll create a ticket for this
relates #2871
Checklist for author
Remove items that aren't applicable, check items that are done.
Reviewability
Documentation
Testing
Follow-up
Screenshots
as applicant, collapsed state and member blocks
expanded
