Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor collapsible animation #2961

Open
aatkin opened this issue Jun 8, 2022 · 0 comments
Open

Refactor collapsible animation #2961

aatkin opened this issue Jun 8, 2022 · 0 comments
Labels
Investigate Needs more investigation, don't know how to do, possibly a bug Technical Debt Improving internal product quality

Comments

@aatkin
Copy link
Collaborator

aatkin commented Jun 8, 2022

This kind of duplicates what was previously handled by the classes/ids. Would be good to refactor this into the atom completely (with CSS animation for opening/closing). Doesn't have to happen now, but we can make sure we have an issue for it.

Originally posted by @Macroz in #2951 (comment)


Currently rems.collapsible/block is using Bootstrap collapse via Javascript API (https://getbootstrap.com/docs/4.1/components/collapse/#via-javascript).

#2951 introduces atom-based state for tracking internal show/hide state that toggles between "hideable collapsed" and "hideable expanded" content. Bootstrap uses jQuery and Javascript to handle dynamic element animation, which maybe needs to be re-created if the functionality is refactored into the atom.

@aatkin aatkin added Technical Debt Improving internal product quality Investigate Needs more investigation, don't know how to do, possibly a bug labels Jun 8, 2022
@meericsc meericsc moved this to Ideas in REMS Task Board May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigate Needs more investigation, don't know how to do, possibly a bug Technical Debt Improving internal product quality
Projects
Status: Ideas
Development

No branches or pull requests

1 participant