Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task highlighting #179

Merged
merged 37 commits into from
Nov 1, 2016
Merged

Task highlighting #179

merged 37 commits into from
Nov 1, 2016

Conversation

fanwgwg
Copy link

@fanwgwg fanwgwg commented Oct 31, 2016

@fanwgwg
Copy link
Author

fanwgwg commented Oct 31, 2016

Gui tests fail, going to investigate on it.

@burnflare
Copy link

@fanwgwg Mind attaching screenshots here of how the new elements look like?

@fanwgwg
Copy link
Author

fanwgwg commented Oct 31, 2016

2016-10-31 at 20 13

This is how it looks like after the changes. @burnflare Is this fine?

@burnflare
Copy link

Ooo nice, variable cell heights. If I have a title that's 2 lines long will it be taller too?

@fanwgwg
Copy link
Author

fanwgwg commented Oct 31, 2016

Yup it will resize automatically!

@rachx
Copy link

rachx commented Oct 31, 2016

Actually, it is showing the last updated time instead of the completion time.
So if you rename a completed task, the time will changed as well >.<
I still think it will be useful to show the time of events/deadlines that have passed

@rachx
Copy link

rachx commented Nov 1, 2016

Fixes #117, #181, #183, #184
Revise #160 after update-model

@burnflare
Copy link

@rachx @fanwgwg Is this good to go in?

Fan Weiguang and others added 6 commits November 2, 2016 00:26
# Conflicts:
#	src/main/java/seedu/agendum/ui/MainWindow.java
#	src/main/java/seedu/agendum/ui/ResultPopUp.java
#	src/test/java/guitests/guihandles/MainMenuHandle.java
#	src/test/java/guitests/guihandles/TaskCardHandle.java
# Conflicts:
#	src/main/java/seedu/agendum/ui/HelpWindow.java
#	src/main/java/seedu/agendum/ui/MainWindow.java
#	src/main/java/seedu/agendum/ui/UiManager.java
@fanwgwg fanwgwg merged commit 4101954 into master Nov 1, 2016
@rachx rachx deleted the task-highlighting branch November 5, 2016 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants