Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ui enhancement #173

Merged
merged 18 commits into from
Oct 30, 2016
Merged

Some ui enhancement #173

merged 18 commits into from
Oct 30, 2016

Conversation

fanwgwg
Copy link

@fanwgwg fanwgwg commented Oct 30, 2016

Fan Weiguang added 10 commits October 26, 2016 21:09
# Conflicts:
#	src/main/java/seedu/agendum/ui/AllTasksPanel.java
#	src/main/java/seedu/agendum/ui/CommandBox.java
#	src/main/java/seedu/agendum/ui/CompletedTasksPanel.java
#	src/main/java/seedu/agendum/ui/MainWindow.java
#	src/main/java/seedu/agendum/ui/OtherTasksPanel.java
# Conflicts:
#	src/main/java/seedu/agendum/ui/CompletedTasksPanel.java
@burnflare
Copy link

untitled

This looks good! Can we try left aligning the text?

@burnflare
Copy link

Feedback: When I hit Esc on the HelpPopup, my keyboard should automatically focus on the command box. Now I need to manually click on the command box after dismissing the help popup

Set message to be left alignment
@fanwgwg
Copy link
Author

fanwgwg commented Oct 30, 2016

Just updated! @burnflare

Fan Weiguang added 2 commits October 30, 2016 19:49
# Conflicts:
#	src/main/java/seedu/agendum/ui/CompletedTasksPanel.java
#	src/main/java/seedu/agendum/ui/DoItAnytimePanel.java
#	src/main/java/seedu/agendum/ui/DoItSoonPanel.java
#	src/main/java/seedu/agendum/ui/MainWindow.java
@rachx
Copy link

rachx commented Oct 30, 2016

Can we use F5 in the command box to make the help window open as well?

@burnflare
Copy link

Why F5?

@rachx
Copy link

rachx commented Oct 30, 2016

F5 works on the main window. Doesn't work within the command box. Alternatively, change both

@rachx
Copy link

rachx commented Oct 30, 2016

Oh wait, I just remember there is CTRL + H. probably should change the docs and help on the top bar

@fanwgwg
Copy link
Author

fanwgwg commented Oct 30, 2016

@burnflare Previously I trie to set the hot key to be ctrl or alt combining some other keys, but it turns out that these keys all fail on travis, only the function key works there, so I change it to F5. @rachx The top bar does not need to change right? Cuz F5 is still used to open the help window, but the other one is used for switching between help window and main window, if the help window is already open. Btw, since the helpwindow final implementation hasn't been confirmed, so no worries about whatever is on the top bar right now.

@rachx
Copy link

rachx commented Oct 30, 2016

@fanwgwg Nicely done :) Can merge if everything pass.
I am not sure how to get the help window to show consistently though

@fanwgwg fanwgwg merged commit 7b30b2b into master Oct 30, 2016
@rachx rachx deleted the ui-enhancement branch October 30, 2016 16:05
@burnflare
Copy link

@fanwgwg I realised now there's a new bug now:
When the message popup disappear, the command box automatically gets keyboard focus, which is great except....... what if I type a command then immediately switch to another app? What happens is that after a few seconds when the message window disappear, I'm force switched back into Agendum.

  1. Type a command
  2. Hit enter
  3. Quickly change to another app.
  4. Wait a few seconds and you'll be forced back into Agendum.

@fanwgwg
Copy link
Author

fanwgwg commented Oct 31, 2016

@burnflare Just updated in the task highlighting branch #179 minutes ago, fix the issue that main window requests focus automatically!

@INCENDE INCENDE changed the title Somw ui enhancement Some ui enhancement Oct 31, 2016
@burnflare
Copy link

Wow, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants