Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage - Add unit tests #174

Merged
merged 95 commits into from
Nov 5, 2016
Merged

Improve test coverage - Add unit tests #174

merged 95 commits into from
Nov 5, 2016

Conversation

INCENDE
Copy link

@INCENDE INCENDE commented Oct 30, 2016 •
edited
Loading

Fixes #159

  • MainApp

Commons:

  • UnmodifiableObservableList

Logic:

  • Add command
  • DateTimeUtils
  • IncorrectCommand
  • Parser
  • Alias/Unalias

Model:

  • UserPrefs
  • UniqueTaskList
  • Name
  • ToDoList
  • Task

UI:

  • UiPartLoader
  • UiManager
  • CompletedTasksPanel

@INCENDE INCENDE changed the title Improve test coverage Improve test coverage - Add unit tests Oct 30, 2016
@burnflare
Copy link

Let's use this PR to collect more

@rachx
Copy link

rachx commented Oct 30, 2016

@INCENDE Can suggest some unit tests to write from other components such as Logic and Model? We will do it

@burnflare
Copy link

+1%!! 🎉
Let's collect till +8% in this PR before merging it?

@rachx
Copy link

rachx commented Oct 30, 2016

Should we collect gui tests and integration tests here or separately?

@burnflare
Copy link

Let's just collect everything here since there's a low chance of conflict with master for test classes.

@INCENDE INCENDE added this to the Week 13: V0.5 milestone Oct 31, 2016
@rachx
Copy link

rachx commented Nov 3, 2016 •
edited
Loading

Make by, from and to case insensitive
#169

@rachx
Copy link

rachx commented Nov 3, 2016

Those under logic are tested and covered by logic manager test.
Might want to add gui tests instead

@INCENDE
Copy link
Author

INCENDE commented Nov 4, 2016 •
edited
Loading

Reached 91%!
Also added new To-Dos

burnflare
burnflare approved these changes Nov 5, 2016
View reviewed changes
Copy link

@burnflare burnflare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of commits here already. Fix those merge conflicts and merge in!

Further changes can be done in another PR

@rachx rachx merged commit 284de28 into master Nov 5, 2016
@burnflare burnflare deleted the improve-test-coverage branch November 6, 2016 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burnflare burnflare burnflare approved these changes

Assignees

@burnflare burnflare

@INCENDE INCENDE

@rachx rachx

Labels
type.enhancement
Projects
None yet
Milestone
Week 13: V0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@INCENDE @burnflare @rachx