Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"from", "to" and "by" should be case insensitive as well #169

Closed
rachx opened this issue Oct 30, 2016 · 3 comments
Closed

"from", "to" and "by" should be case insensitive as well #169

rachx opened this issue Oct 30, 2016 · 3 comments

Comments

@rachx
Copy link

rachx commented Oct 30, 2016

Update parsing for add/schedule.
If possible, add other words such as "on" and "at"
Should there be an invalid command if a user specifies a deadline + start/end time?
"add go for a run from 2pm to 4pm by friday" - behavior is not well-defined (anything with by, from and to)

@burnflare
Copy link

@rachx Can I assign this back to you? Don't think I'll have time to finish this over the weekend given the remaining GCal integration work

@rachx
Copy link
Author

rachx commented Nov 5, 2016

@burnflare I made from/by/to case insensitive in the improve-test-coverage branch and ensured that if a valid time is provided, it only accepts a deadline or event time (with from and to) not both.

Do check after it is merged into master and compare against the latest user guide in the v0.4 docs pr.

If you find time to refactor the code such that the date time parser output the start and end time, then we can consider adding "on" and "at"

@rachx
Copy link
Author

rachx commented Nov 6, 2016

Okay to be addressed by #204

@rachx rachx closed this as completed Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants