Update instructions: nuke VDI and OOD; add ARE #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about ARE? |
|
|
|
perhaps we wanna drop testing on python < 3.9? |
navidcy
commented
Jan 25, 2023
angus-g
changed the title
angus-g
reviewed
Jan 25, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 54.94% 54.94%
=======================================
Files 22 22
Lines 1811 1811
=======================================
Hits 995 995
Misses 816 816 ☔ View full report in Codecov by Sentry. |
|
I believe this is ready for review again ;) |
navidcy
changed the title
angus-g
requested changes
Feb 28, 2024
Co-authored-by: Angus Gibson <[email protected]>
Co-authored-by: Angus Gibson <[email protected]>
Co-authored-by: Angus Gibson <[email protected]>
Co-authored-by: Angus Gibson <[email protected]>
|
Thanks! Looks good from here. I'll let Andrew respond to your question above, but otherwise I'm happy. |
|
I've redirected the Cookbook documentation to that for the Recipes (#340), so I don't think this applies any more. This will probably fade out of relevance with the introduction of the Intake catalogue anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the instructions and removes all references to deprecated VDI system.
Closes #272
Closes #328