Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign change warning fix #382

Merged
merged 2 commits into from
Dec 31, 2019
Merged

Sign change warning fix #382

merged 2 commits into from
Dec 31, 2019

Conversation

henryiii
Copy link
Collaborator

Fix #367.

Also using std::size_t instead of size_t since this is C++ not C.

@codecov
Copy link

codecov bot commented Dec 31, 2019

Codecov Report

Merging #382 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #382   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3366   3366           
=====================================
  Hits         3366   3366
Impacted Files Coverage Δ
include/CLI/Split.hpp 100% <ø> (ø) ⬆️
include/CLI/Timer.hpp 100% <100%> (ø) ⬆️
include/CLI/Validators.hpp 100% <100%> (ø) ⬆️
include/CLI/TypeTools.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/StringTools.hpp 100% <100%> (ø) ⬆️
include/CLI/FormatterFwd.hpp 100% <100%> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <100%> (ø) ⬆️
include/CLI/Error.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef88ee...eac166a. Read the comment docs.

@henryiii henryiii merged commit d5cd986 into master Dec 31, 2019
@henryiii henryiii deleted the henryiii-warnfix branch December 31, 2019 15:35
@henryiii henryiii mentioned this pull request Dec 31, 2019
13 tasks
@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler warning with -Wsign-conversion
1 participant