Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warning with -Wsign-conversion #367

Closed
ettom opened this issue Dec 11, 2019 · 0 comments · Fixed by #382
Closed

Compiler warning with -Wsign-conversion #367

ettom opened this issue Dec 11, 2019 · 0 comments · Fixed by #382

Comments

@ettom
Copy link

ettom commented Dec 11, 2019

Option.hpp:479:34: warning: implicit conversion changes signedness: 'int' to 'std::vector::size_type' (aka 'unsigned long') [-Wsign-conversion]
            return &(validators_[index]);
                     ~~~~~~~~~~~ ^~~~~
Option.hpp:1151:70: warning: implicit conversion changes signedness: 'int' to 'const unsigned long' [-Wsign-conversion]
                size_t trim_size = std::min<size_t>(std::max<size_t>(get_items_expected_max(), 1), original.size());
                                                    ~~~              ^~~~~~~~~~~~~~~~~~~~~~~~
Option.hpp:1153:49: warning: implicit conversion changes signedness: 'size_t' (aka 'unsigned long') to '__gnu_cxx::__normal_iterator<const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > *, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::difference_type' (aka 'long') [-Wsign-conversion]
                    res.assign(original.end() - trim_size, original.end());
                                              ~ ^~~~~~~~~
Option.hpp:1158:66: warning: implicit conversion changes signedness: 'int' to 'const unsigned long' [-Wsign-conversion]
            size_t trim_size = std::min<size_t>(std::max<size_t>(get_items_expected_max(), 1), original.size());
                                                ~~~              ^~~~~~~~~~~~~~~~~~~~~~~~
Option.hpp:1160:65: warning: implicit conversion changes signedness: 'size_t' (aka 'unsigned long') to '__gnu_cxx::__normal_iterator<const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > *, std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >::difference_type' (aka 'long') [-Wsign-conversion]
                res.assign(original.begin(), original.begin() + trim_size);
                                                              ~ ^~~~~~~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant