fix calibration solution reading #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwmeyers
approved these changes
Feb 1, 2024
bwmeyers
added a commit
that referenced
this pull request
Feb 1, 2024
bwmeyers
added a commit
that referenced
this pull request
Feb 1, 2024
* changed calibration read for Offringa to use requested number of channels to process * fix GPU memory address alignment errors, add comments/debug code * included extra debug info in Offringa-style solution reads * fix C-standard issue in DEBUG block * added debug output * add debug output * update variable names to match fix from PR #43, removed commented statements * fixed mildly pedantic int vs. unsigned int string formatting warning * fixed the formatting for real this time...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So these are the fixes I need to do for the calibration solution to be loaded correctly. It should work when the calibration solution has the same set of channels as the input vcs data