Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divide by zero in hbnew calculation. #334

Closed
wants to merge 24 commits into from
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
158b443
Fix nt_zbgc_frac
dabail10 Feb 18, 2020
93c6ab4
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Feb 20, 2020
8f3263d
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Feb 24, 2020
776316e
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Apr 2, 2020
a2219bf
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Apr 6, 2020
2abbfa7
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Apr 22, 2020
9bb6df7
Merge branch 'master' of https://github.com/ESCOMP/Icepack
dabail10 Apr 22, 2020
b72c0bc
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 May 15, 2020
1f0195e
Merge branch 'master' of https://github.com/ESCOMP/Icepack
dabail10 May 15, 2020
78c0aef
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 May 29, 2020
6a603cd
Merge branch 'master' of https://github.com/ESCOMP/Icepack
dabail10 May 29, 2020
d353104
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Jun 10, 2020
d9273f1
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Jun 24, 2020
2ec16b0
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Jul 6, 2020
a40bbf9
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Jul 13, 2020
faa181f
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Jul 16, 2020
a2950cc
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Jul 24, 2020
e920664
New developer guide module on adding diagnostics
dabail10 Jul 28, 2020
c4cc6da
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Aug 10, 2020
aae7e7c
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack
dabail10 Aug 19, 2020
259f102
Updating to master
dabail10 Aug 19, 2020
0a33d12
Bug fix for hbnew calculation
dabail10 Aug 19, 2020
2b92358
add units to comment
dabail10 Aug 20, 2020
130627a
Merge branch 'master' of https://github.com/CICE-Consortium/Icepack i…
dabail10 Dec 2, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions columnphysics/icepack_therm_itd.F90
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ subroutine linear_itd (ncat, hin_max, &

real (kind=dbl_kind) :: &
slope , & ! rate of change of dhice with hice
denom , & ! denominator in hbnew calculation (m)
dh0 , & ! change in ice thickness at h = 0
da0 , & ! area melting from category 1
damax , & ! max allowed reduction in category 1 area
Expand Down Expand Up @@ -306,8 +307,8 @@ subroutine linear_itd (ncat, hin_max, &
if (hicen_init(n) > puny .and. &
hicen_init(n+1) > puny) then
! interpolate between adjacent category growth rates
slope = (dhicen(n+1) - dhicen(n)) / &
(hicen_init(n+1) - hicen_init(n))
denom = max(puny,hicen_init(n+1) - hicen_init(n))
slope = (dhicen(n+1) - dhicen(n)) / denom
hbnew(n) = hin_max(n) + dhicen(n) &
+ slope * (hin_max(n) - hicen_init(n))
elseif (hicen_init(n) > puny) then ! hicen_init(n+1)=0
Expand Down