Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix divide by zero in hbnew calculation. #334

Closed
wants to merge 24 commits into from

Conversation

dabail10
Copy link
Contributor

@dabail10 dabail10 commented Aug 19, 2020

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    This is a fix for the potential divide by zero in Issue Divide by zero bug #333.
  • Developer(s):
    dabail10 (D. Bailey)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_mach_forks#izumi
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    This was spotted by Denise Worthen in the NOAA EMC test suite, Issue debug regression test fails in ufs-s2s-model CICE#502. So, it can happen on occasion. This fix is bfb in our current test suite. Should probably be brought into CICE soon.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment re comments in the code is that if there is a unit associated with it, to provide it (m here). But this is fine!

@dabail10 dabail10 linked an issue Aug 20, 2020 that may be closed by this pull request
@apcraig
Copy link
Contributor

apcraig commented Aug 21, 2020

Is this PR on hold until the issue is discussed further in #333?

@dabail10
Copy link
Contributor Author

Yes, this is on hold for now.

@apcraig
Copy link
Contributor

apcraig commented Mar 16, 2021

See #337

@apcraig apcraig closed this Mar 16, 2021
@dabail10 dabail10 deleted the slope branch October 4, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Divide by zero bug
3 participants