Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOAA operations and research computers #317

Closed
wants to merge 49 commits into from
Closed

NOAA operations and research computers #317

wants to merge 49 commits into from

Conversation

rgrumbine
Copy link
Contributor

Additions to run regression tests on NWS operational system 'phase2' and NOAA R+D system 'theia':

  • Developer(s):
    Robert Grumbine

  • Are the code changes bit for bit, different at roundoff level, or more substantial?
    Bit for bit

  • Does this PR create or have dependencies on Icepack or any other models?
    No

  • Is the documentation being updated with this PR? (Y/N)
    If not, does the documentation need to be updated separately at a later time? (Y/N)

No, no

  • Other Relevant Details:

Added to .gitignore to ignore the testsuite files and directories.
Though present, the theia_gnu and theia_pgi configurations have not been confirmed to pass the full regression suite.

@rgrumbine rgrumbine closed this May 29, 2019
@rgrumbine rgrumbine reopened this May 29, 2019
@apcraig
Copy link
Contributor

apcraig commented May 29, 2019

The automated testing is failing. It cannot find the icepack code. It looks like the icepack submodule was removed on this branch. Maybe that was done temporarily and for testing, but we'll need to fix that. I think we just need to revert the .gitmodules file. Otherwise, the changes are largely just machine ports. Please revert the .gitmodules file and push and then lets confirm the automated testing is passing.

@rgrumbine
Copy link
Contributor Author

I restored the .gitmodules and Travis still fails. It looks like it still can't find the icepack. Is .gitmodules case sensitive?

@apcraig
Copy link
Contributor

apcraig commented May 30, 2019

I had another look and triggered another build just to make sure it wasn't travis. I'm not entirely sure what is happening or how this came about, but the icepack submodule is still not there. You can see at the bottom of the diffs that "icepack" has been removed. So maybe it wasn't enough to revert the .gitmodules file, maybe more needs to be done. Maybe the icepack submodule needs to be formally added some other way again. If you need some help, let me know. One option might be to create a new branch and then move the changes on this branch to the new branch, delete this PR, then create a new PR on the new branch. Just make sure icepack is not removed on the new branch. I'm sure we can also bring icepack back on the current branch somehow.

@eclare108213
Copy link
Contributor

There are some examples for working with Icepack as a submodule here:
https://github.com/CICE-Consortium/About-Us/wiki/Git-Workflow-Guidance#submodules

@apcraig
Copy link
Contributor

apcraig commented May 30, 2019

It's still not running in travis. The .gitmodules now is different again. And the diff suggests that 46 files were changed in Icepack. I think we need a new PR. I have added a section in https://github.com/CICE-Consortium/About-Us/wiki/Git-Workflow-Guidance#pull-requests about how to refresh the PR by shifting to a new branch. One problem is that the current branch is "rgrumbine:master". We recommend not using master to do development and as a result, you will not be able to follow the process outlined in the document. This is what I suggest. I can create a branch in my fork and pull your "master" mods onto my branch. I can then create the PR. At that point, @rgrumbine can either delete the CICE fork and create a new one clean again or revert the master in the current fork to the version in the CICE-Consortium and then try not to do development on master again. That should both clean up the rgrumbine fork and get the PR onto the trunk. I will setup a branch in my fork now.

@rgrumbine
Copy link
Contributor Author

rgrumbine commented May 31, 2019 via email

@rgrumbine
Copy link
Contributor Author

rgrumbine commented May 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants