Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

longitude dependence of solar time #3

Closed
eclare108213 opened this issue May 31, 2017 · 5 comments
Closed

longitude dependence of solar time #3

eclare108213 opened this issue May 31, 2017 · 5 comments
Assignees
@eclare108213 @dabail10 @rgrumbine
Labels
Forcing Priority: Medium Testing

Comments

@eclare108213
Copy link
Contributor

From: Pedro Duarte [email protected]
Sent: Monday, May 22, 2017 8:13 AM

I have just noticed that in ice_forcing.F90, in the subroutine compute_shortwave there is the following equation to calculate solar time:
solar_time = mod(real(sec,kind=dbl_kind),secday)/c3600 &
+ c12sin(p5TLON(i,j))

As I understand, the second term is to correct solar time as a function of longitude. However, I think there may be an error here since c12sin(p5TLON(i,j)) should return 6 hours when TLON = 90 and it returns ~8.5 hours. I wonder why not using a simple linear function here since solar time varies one hour per 15 degrees? Or am I missing something here?
@dabail10
Copy link
Contributor

dabail10 commented Jun 1, 2017

Just a thought here. This was used for the AOMIP protocol and I believe there are some corrections for the eccentricity of the Earth's orbit. There is an interesting page here:

http://www.pveducation.org/pvcdrom/2-properties-sunlight/solar-time

This formula gives GMT+12 precisely at 180 degrees. Elizabeth, do you recall discussions about this during AOMIP?

Dave

@eclare108213
Copy link
Contributor Author

@dabail10 I do not recall conversations about this during AOMIP -- I pretty much just took the documentation that was given and coded it up. If this formula is technically correct, why would it be returning the wrong value when TLON=90?

@dabail10
Copy link
Contributor

You can assign this issue to me. I can't assign it to myself.

@eclare108213
Copy link
Contributor Author

It seems like you ought to be able to claim it yourself if you wanted to do it...
@apcraig Do we need to have permissions set differently, or is this standard github procedure?

@eclare108213 eclare108213 self-assigned this Mar 10, 2018
eclare108213 pushed a commit that referenced this issue Mar 31, 2018
@anders-dc
Merge pull request #3 from apcraig/travis
b871231 
update travis suite and add quiet mode to scripts
apcraig referenced this issue in apcraig/CICE Sep 24, 2018
@apcraig
mods for nag compiler failure (#3)
975e4b2
apcraig referenced this issue in apcraig/CICE Sep 24, 2018
@apcraig @mhrib
mods for nag compiler failure (#3)
2e6e351
apcraig referenced this issue in apcraig/CICE Sep 27, 2018
@apcraig
mods for nag compiler failure (#3)
260b3ef
apcraig pushed a commit that referenced this issue Sep 28, 2018
@mhrib @apcraig
Alloc dyn4 (#194)
8492af9 
* Allocatable dynamics version using namelist

* Updated ice_in according to "Allocated Dynamics"

* update scripts to automatically set namelist associated with grids and blocks

* fix uarea initialization related to NYGLOB cpp (#1)

* update pgi optimzation to address reproducibility problems (#2)

* mods for nag compiler failure (#3)

* Update to Consortium master bbec5d1 (#4)

* update pgi compiler optimization to address reproducibility problems

* Dummy and unused variables. (#180)

* Remove some dummy arguments and unused variables.

* Dummy variable cleanup

* Cleanup

* Remove icepack from commit

* Reset icepack master

* Fix

* Fix

* Update icepack

* fix

* Fix flush ifdef logic

* Uninitialized variables.

* Additional initialization

* Update dummy

* more dummy fixes

* More hobart changes

* Update Hobart Intel settings

* Additional Hobart Intel changes

* Update icepack

* Some tweaks to dummy variables

* Remove some initialization code.

* Only remove istat checks in one routine.

* update icepack (#188)

* fix ice_abort error in ice_state.F90 (#5)
@apcraig apcraig mentioned this issue Oct 23, 2018
Merged
@dabail10 dabail10 mentioned this issue Jun 13, 2019
Merged
eclare108213 pushed a commit that referenced this issue Aug 30, 2019
@dabail10 @eclare108213
Local Solar Time Computation (#323)
804b703 
* Fix local solar time

* Add line for going past 24

* New LST calculation

Addresses #3.
@phil-blain
Copy link
Member

I think this can be closed as it was fixed in #323.

JFLemieux73 pushed a commit to JFLemieux73/CICE that referenced this issue Nov 16, 2021
@phil-blain
ice_dyn_shared: add 'viscous_coeffs_and_rep_pressure_T' subroutine (C…
50d67f8 
…ICE-Consortium#3)

Add a subroutine mimicking what 'viscous_coeffs_and_rep_pressure' does,
but at a single location.

Name it '*_T' since it's going to be used to compute the viscous
coefficients and replacement pressure at the T point.
anton-seaice pushed a commit to anton-seaice/CICE that referenced this issue Dec 1, 2023
@DeniseWorthen
Merge pull request CICE-Consortium#3 from CICE-Consortium/master
71d2ded
anton-seaice pushed a commit to anton-seaice/CICE that referenced this issue Dec 1, 2023
@dabail10
Merge pull request CICE-Consortium#3 from mvertens/mvertens/nuopc
7e43703 
changes to satisfy ufsatm and cesm requirements for pot temp and density from atm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eclare108213 eclare108213

@dabail10 dabail10

@rgrumbine rgrumbine

Labels
Forcing Priority: Medium Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eclare108213 @dabail10 @rgrumbine @phil-blain