Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gswp3drvflds #454

Merged
merged 19 commits into from
Jun 15, 2016
Merged

Gswp3drvflds #454

merged 19 commits into from
Jun 15, 2016

Conversation

ekluzek
Copy link

@ekluzek ekluzek commented Jun 8, 2016

Add in option for CLMGSWP3 for datm. Also add in capability for driver namelist generation to merge CAM and CLM drv_flds_in namelists together,
and abort on a conflict. Add in testing of driver namelist. Work on SSP test and add SPL testcase. Add option to Namelist.pm->merge_nl to die on
conflict. change notes for Namelist.pm to be "!#" instead of "#!". Fix namelist test to work. Remove messing with drv_flds_in file in
preview_namelists.

Test namelist changes: showed that namelists are identical for ALL tests (all machines, all compilers, all test lists) in cesm1_5_beta06
Test status: bit-for-bit

Fixes: #324, #315, #56
User interface changes?: None

Code review: Design review a few months ago with: Ben A., Mariana V., Jim Edwards, Bill S., Erik K.

@ekluzek
Copy link
Author

ekluzek commented Jun 13, 2016

Adding @mvertens and @fischer-ncar. Could one of you complete this pull request, since Jim is out? Or assign it to someone else? Thanks

@mvertens
Copy link

Chris - can you please handle this.

Mariana

On Mon, Jun 13, 2016 at 4:25 PM, Erik Kluzek [email protected]
wrote:

Adding @mvertens https://github.com/mvertens and @fischer-ncar
https://github.com/fischer-ncar. Could one of you complete this pull
request, since Jim is out? Or assign it to someone else? Thanks


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#454 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AHlxE8nW_AOXm93Uwo9bgIVSmYMHl7Tdks5qLdjsgaJpZM4IxL9n
.

@fischer-ncar fischer-ncar merged commit 2a3f939 into master Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants