Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSP test treats ref1 case as the main case #56

Closed
billsacks opened this issue Jul 17, 2015 · 3 comments
Closed

SSP test treats ref1 case as the main case #56

billsacks opened this issue Jul 17, 2015 · 3 comments
Assignees
Milestone

Comments

@billsacks
Copy link
Member

For most tests with a ref case, I believe the standard is to have the "bare" case name be the main case, in which comparisons with baselines (etc.) occur. However, this is reversed for the SSP test.

This lack of consistency is a problem for users of the test, and also for tools that post-process test results, such as baseline_gen_comp.

I propose that the SSP test be reworked to switch the meaning of the ref1 case and the "bare" case.

@mvertens
Copy link

I completely agree. This has confused me in the past and I always have to revisit the logic if there are any issues.

jedwards4b added a commit that referenced this issue Mar 15, 2016
Bug fixes, documentation improvement, build flags
@billsacks billsacks added this to the cesm2 milestone Apr 27, 2016
@jedwards4b
Copy link

To be addressed in python

@ekluzek
Copy link

ekluzek commented Apr 27, 2016

@billsacks and I talked about this and I just need to change the name of the second case so that it's labeled SSP (the new desired name is SPL for spinup Land -- there is a SPO case for the ocean). I want to make sure the second case is the one that is saved and compared because you could do something to screw it up, but still have the first case compare exactly.

@ekluzek ekluzek mentioned this issue Jun 8, 2016
@ekluzek ekluzek closed this as completed Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants