Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version strings from file names #247

Merged
merged 13 commits into from
Jun 30, 2023
Merged

Remove version strings from file names #247

merged 13 commits into from
Jun 30, 2023

Conversation

ahouseholder
Copy link
Contributor

resolves #246

@ahouseholder ahouseholder self-assigned this Jun 16, 2023
@ahouseholder ahouseholder linked an issue Jun 16, 2023 that may be closed by this pull request
@ahouseholder ahouseholder added this to the SSVC v2.1 milestone Jun 16, 2023
ahouseholder and others added 6 commits June 28, 2023 13:26
… feature/fix-246

* 'feature/fix-246' of https://github.com/CERTCC/SSVC:
  add subsubsection header for tree versioning
  Update link to SSVC_Provision.schema.json
  Update link to SSVC_Computed.schema.json
  Update 055_decision-points_2.md (#250)
  Two small typo fixes (#253)
  Replace Utility with Automatable in Deployer tree (#248)
  Add detail about customization, tree sharing, and decision point scope (#242)
  add text to point ahead to "Information Changes over Time"
  bulletize list

# Conflicts:
#	ssvc-calc/SSVC_Computed.schema.json
#	ssvc-calc/SSVC_Provision.schema.json
@ahouseholder ahouseholder temporarily deployed to github-pages June 30, 2023 14:13 — with GitHub Pages Inactive
@ahouseholder ahouseholder temporarily deployed to github-pages June 30, 2023 14:24 — with GitHub Pages Inactive
Copy link
Contributor

@cgyarbrough cgyarbrough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur and approve these changes. I presume that the SSVC Provision Table would change with each customer, correct? I know there is a CISA-specific component for this run.

@ahouseholder
Copy link
Contributor Author

I presume that the SSVC Provision Table would change with each customer, correct? I know there is a CISA-specific component for this run.

We include the CISA tree because we had it from helping to develop https://www.cisa.gov/ssvc-calculator (which is based on the ssvc-calc included in this repo.

However, it strikes me that the default tree that loads for our calculator should probably not be the CISA-tuned one, but instead one of the ones described in the document. I'll create a separate issue to capture that.

@laurie-tyz
Copy link
Contributor

@ahouseholder & @cgyarbrough we need to establish our own tree.

@ahouseholder ahouseholder merged commit 8236331 into main Jun 30, 2023
@ahouseholder
Copy link
Contributor Author

@ahouseholder & @cgyarbrough we need to establish our own tree.

@laurie-tyz See #257 for the proposed change and #258 for the PR that implements it

@ahouseholder ahouseholder deleted the feature/fix-246 branch June 30, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop including version numbers in file names
3 participants