-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Utility with Automatable in Deployer tree #248
Conversation
v2 had 108 rows, v2_1 has 72 rows. This reflects the change from Utility having 3 options to Automatable only having 2. Utility = laborious implies Automatable = no Utility = super effective implies Automatable = yes Utility = efficient is ambiguous about the Automatable value. So all I did was eliminate the Utility = efficient rows from the CSV and kept the values for "laborious" and "super effective" It might be necessary to tune these somewhat but at least this version is 100% consistent with what information was already present in the v2 CSV file.
Note this effectively translates to - pruning out the "efficient" branch of Utility - renaming "Utility" to "Automatable" - renaming "laborious" to "no" - renaming "super effective" to "yes" I used overleaf to generate the pdf from the tex file.
Deployer tree JSON version with no Utility/Value Density. 103 nodes and 72 decisions.
The file was obsoleted by deployer-options_v2_1.csv
…x_238 * 'main' of https://github.com/CERTCC/SSVC: Updating text to conform to Human Impact change (#236) # Conflicts: # doc/md_src_files/060_decision-trees.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct for clean up and simplification of Deployer tree
Removing sync defer from D3 library to ensure init scripts do not fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. I made #249 for reviewing the suggested decision values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the changes submitted. Simplification is usually a good thing. We discussed these changes in our team meeting.
… feature/fix-246 * 'feature/fix-246' of https://github.com/CERTCC/SSVC: add subsubsection header for tree versioning Update link to SSVC_Provision.schema.json Update link to SSVC_Computed.schema.json Update 055_decision-points_2.md (#250) Two small typo fixes (#253) Replace Utility with Automatable in Deployer tree (#248) Add detail about customization, tree sharing, and decision point scope (#242) add text to point ahead to "Information Changes over Time" bulletize list # Conflicts: # ssvc-calc/SSVC_Computed.schema.json # ssvc-calc/SSVC_Provision.schema.json
Resolves #238
See discussion in #221 for background