Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not add empty list in header #6440

Merged
merged 1 commit into from
Aug 29, 2023
Merged

do not add empty list in header #6440

merged 1 commit into from
Aug 29, 2023

Conversation

BobanL
Copy link
Contributor

@BobanL BobanL commented Aug 29, 2023 •
edited
Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Only include the list in the header only if there is something inside.

Additional Information

  • decisions that were made
  • notice of future work that needs to be done

Testing

  • Deployed in dev 1

Screenshots / Demos

Desktop nav:
Now:
image
Before:
image

Mobile Nav
Now:
image
Before:
image

Still works when user ghosts into org:
image

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@BobanL BobanL temporarily deployed to Dev August 29, 2023 12:41 — with GitHub Actions Inactive
@BobanL BobanL changed the title hide header in list if empty don't add list in header if empty Aug 29, 2023
@BobanL BobanL changed the title don't add list in header if empty don't add empty list in header Aug 29, 2023
@BobanL BobanL changed the title don't add empty list in header do not add empty list in header Aug 29, 2023
@BobanL BobanL marked this pull request as ready for review August 29, 2023 14:13
@BobanL BobanL enabled auto-merge August 29, 2023 14:13
johanna-skylight
johanna-skylight approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@johanna-skylight johanna-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in dev1 looks good! thanks :D

@BobanL BobanL added this pull request to the merge queue Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@BobanL BobanL added this pull request to the merge queue Aug 29, 2023
Merged via the queue into main with commit 21b9a55 Aug 29, 2023
@BobanL BobanL deleted the boban/6411-hide-list-if-empty-in-header branch August 29, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanna-skylight johanna-skylight johanna-skylight approved these changes

@fzhao99 fzhao99 fzhao99 approved these changes

@emyl3 emyl3 Awaiting requested review from emyl3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Main menu site admin] Org admin menu is hidden but still part of the DOM
3 participants
@BobanL @fzhao99 @johanna-skylight