Add unarchive patient support admin page #6299

emyl3 · 2023-08-09T12:37:10Z

FRONTEND PULL REQUEST

Related Issue

Resolves [Unarchive patient] Archived patients table #6063

Changes Proposed

adds a page to unarchive patients for site admins
- supports filtering by organization and testing facility
- support pagination of archived patients results
- patients who are part of all facilities for that org will show up in a testing facility result because of the way we retrieve facilities on the backend

Additional Information

Unarchive button functionality will be added in [Unarchive patient] Unarchive action #6064

Testing

🌈 Now available on dev1 🌈
https://dev.simplereport.gov/app/admin/unarchive-patient

org with archived patients - Test org el B

Screenshots / Demos

@jayna-SkylightDigital - Here are some screenshots of the copy we didn't discuss explicitly that I wanted to make sure was OK with you 😸

Instructions copy

No facility in selected org

emyl3 · 2023-08-10T15:21:46Z

frontend/src/app/supportAdmin/TenantDataAccess/operations.graphql

@@ -1,5 +1,6 @@
 query GetOrganizations($identityVerified: Boolean) {
    organizations(identityVerified: $identityVerified) {
+        internalId


⚠️ the GetOrganizationsWithFacilities query requries the org's internalId as a param

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.tsx

emyl3 · 2023-08-10T16:26:46Z

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatientContainer.tsx

+  const [selectedFacilityId, setSelectedFacilityId] = useState<string>("");
+  const [archivedPatientsCount, setArchivedPatientsCount] = useState<
+    number | undefined
+  >(undefined);


⚠️ setting the patients count and patients default to be undefined to differentiate from when we get 0 results or no patients back (for UI purposes)

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.tsx

emyl3 · 2023-08-10T16:34:53Z

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.tsx

+      await fetchAndSetArchivedPatients(orgId, facilityId, organizations);
+      await fetchAndSetArchivedPatientsCount(orgId, facilityId, organizations);
+      // clear pagination on search submit
+      navigate(`${unarchivePatientPageUrl}${searchParams}`);


⚠️ not sure if this is too hacky...
But our pagination component adds /{number} to the end of the path so if someone was on the 3rd page of results their path would be updated to /admin/unarchive-patient/3

At that point if they select a new facility and new org and click "Search" and that result does not have 3 pages of results it will display "No result" which I found confusing.

The only downside is the get patients query runs 2x in the above scenario (one with the page number of 2 and one with page number of 0)

Let me know if I need to elaborate more 😅

frontend/src/app/supportAdmin/UnarchivePatients/operations.graphql

BobanL

Ran axe tool on all the page combos in dev2 and looked good!

johanna-skylight · 2023-08-11T14:07:38Z

frontend/src/app/supportAdmin/SupportAdminRoutes.tsx

@@ -39,6 +40,10 @@ const SupportAdminRoutes: React.FC<Props> = ({ isAdmin }) => {
        path="tenant-data-access"
        element={<TenantDataAccessFormContainer />}
      />
+      <Route path={"unarchive-patient"}>
+        <Route path=":pageNumber" element={<UnarchivePatientContainer />} />
+        <Route path="" element={<UnarchivePatientContainer />} />


Is there a way to set the route just once and fallback to a default value if no page number is passed?. Also how can the user pass a page number but the facility selected is not needed?.

Ahh yes! It looks like there is a way to set the route once!

I think the only way a user can pass a page number without having selected a facility is by manipulating the url and appending a page number but nothing would display since they have not selected an org or facility

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatientContainer.tsx

emyl3 · 2023-08-11T16:13:31Z

Discussed async with @jayna-SkylightDigital and @johanna-skylight to make this page and the manage facilities page (#5847) more aligned with one another.

going to add a clear filters button
and header before the table is displayed

manage facility for reference :)

cypress/e2e/11-unarchive_patient.cy.js

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.tsx

sonarqubecloud · 2023-08-18T20:50:16Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

90.6% Coverage
0.0% Duplication

emyl3 · 2023-08-18T20:51:51Z

@BobanL @fzhao99 @johanna-skylight @mehansen Ready for re-review!!!

@johanna-skylight I left the loading mask when first loading the page since we have 10k+ orgs in prod (id verified and not deleted -- which, I wonder, if we should switch to a combobox later on if support mentions if it is tough to find the org...)

fzhao99 · 2023-08-21T13:03:54Z

@BobanL @fzhao99 @johanna-skylight @mehansen Ready for re-review!!!

@johanna-skylight I left the loading mask when first loading the page since we have 10k+ orgs in prod (id verified and not deleted -- which, I wonder, if we should switch to a combobox later on if support mentions if it is tough to find the org...)

yeah I think we want to switch to a combo box now. they had this request on the ghosting screen way back when I first joined and I think a similar issue applies here.

johanna-skylight · 2023-08-21T13:08:38Z

@BobanL @fzhao99 @johanna-skylight @mehansen Ready for re-review!!!
@johanna-skylight I left the loading mask when first loading the page since we have 10k+ orgs in prod (id verified and not deleted -- which, I wonder, if we should switch to a combobox later on if support mentions if it is tough to find the org...)

yeah I think we want to switch to a combo box now. they had this request on the ghosting screen way back when I first joined and I think a similar issue applies here.

Oh but that would mean that we also need to change it for the manage facility page. I think we should create a ticket to migrate the dropdown from this page and manage facility as a follow up.

Tagging : @mehansen @jayna-SkylightDigital

emyl3 · 2023-08-21T15:17:51Z

@BobanL @fzhao99 @johanna-skylight @mehansen Ready for re-review!!!
@johanna-skylight I left the loading mask when first loading the page since we have 10k+ orgs in prod (id verified and not deleted -- which, I wonder, if we should switch to a combobox later on if support mentions if it is tough to find the org...)

yeah I think we want to switch to a combo box now. they had this request on the ghosting screen way back when I first joined and I think a similar issue applies here.

Oh but that would mean that we also need to change it for the manage facility page. I think we should create a ticket to migrate the dropdown from this page and manage facility as a follow up.

Tagging : @mehansen @jayna-SkylightDigital

Thanks everyone! I'll create a ticket -- feel free to edit and update as you see fit @jayna-SkylightDigital and @mehansen

emyl3 · 2023-08-21T15:27:46Z

@johanna-skylight @fzhao99 @jayna-SkylightDigital @mehansen
#6393
ticket created to track this effort

emyl3 force-pushed the elisa/6063-archived-patients-table branch 5 times, most recently from 55d36bb to 46d5a55 Compare August 10, 2023 15:15

emyl3 commented Aug 10, 2023

View reviewed changes

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.tsx Outdated Show resolved Hide resolved

emyl3 commented Aug 10, 2023

View reviewed changes

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.tsx Outdated Show resolved Hide resolved

emyl3 commented Aug 10, 2023

View reviewed changes

emyl3 temporarily deployed to Dev2 August 10, 2023 17:24 — with GitHub Actions Inactive

emyl3 marked this pull request as ready for review August 10, 2023 18:50

emyl3 requested review from mehansen, BobanL, fzhao99, johanna-skylight and jayna-SkylightDigital August 10, 2023 18:51

mehansen reviewed Aug 10, 2023

View reviewed changes

frontend/src/app/supportAdmin/UnarchivePatients/operations.graphql Show resolved Hide resolved

BobanL previously approved these changes Aug 11, 2023

View reviewed changes

johanna-skylight reviewed Aug 11, 2023

View reviewed changes

emyl3 dismissed BobanL’s stale review via ababfa3 August 16, 2023 19:48

emyl3 force-pushed the elisa/6063-archived-patients-table branch 3 times, most recently from ae66150 to c06255a Compare August 16, 2023 20:30

emyl3 commented Aug 16, 2023

View reviewed changes

cypress/e2e/11-unarchive_patient.cy.js Outdated Show resolved Hide resolved

emyl3 commented Aug 16, 2023

View reviewed changes

frontend/src/app/supportAdmin/UnarchivePatients/UnarchivePatient.tsx Outdated Show resolved Hide resolved

emyl3 force-pushed the elisa/6063-archived-patients-table branch 2 times, most recently from fcae57f to dfd380b Compare August 17, 2023 15:37

emyl3 temporarily deployed to Dev August 17, 2023 16:08 — with GitHub Actions Inactive

emyl3 added 6 commits August 18, 2023 15:14

fix e2e

61716a8

address feedback

f618724

update css

589f88c

use onClick for pagination

22c703d

Add jest-axe tests

dffe3d3

Fix merge issue

e54c1ec

emyl3 force-pushed the elisa/6063-archived-patients-table branch from 2419e3d to e54c1ec Compare August 18, 2023 19:14

remove comment

61c3c25

emyl3 temporarily deployed to Dev August 18, 2023 19:49 — with GitHub Actions Inactive

fix code smell

e174ad9

emyl3 temporarily deployed to Dev August 18, 2023 20:16 — with GitHub Actions Inactive

actually fix code smell

2968746

emyl3 requested review from mehansen, fzhao99, BobanL and johanna-skylight August 18, 2023 20:52

emyl3 temporarily deployed to Dev August 18, 2023 21:12 — with GitHub Actions Inactive

johanna-skylight approved these changes Aug 21, 2023

View reviewed changes

fzhao99 approved these changes Aug 21, 2023

View reviewed changes

emyl3 added this pull request to the merge queue Aug 21, 2023

emyl3 mentioned this pull request Aug 21, 2023

Change selects/dropdowns in support admin manage facility and unarchive patient pages #6393

Closed

Merged via the queue into main with commit 794f0a6 Aug 21, 2023

emyl3 deleted the elisa/6063-archived-patients-table branch August 21, 2023 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unarchive patient support admin page #6299

Add unarchive patient support admin page #6299

emyl3 commented Aug 9, 2023 •

edited

Loading

emyl3 Aug 10, 2023 •

edited

Loading

emyl3 Aug 10, 2023

emyl3 Aug 10, 2023

BobanL left a comment

johanna-skylight Aug 11, 2023

emyl3 Aug 11, 2023

emyl3 commented Aug 11, 2023

sonarqubecloud bot commented Aug 18, 2023

emyl3 commented Aug 18, 2023

fzhao99 commented Aug 21, 2023

johanna-skylight commented Aug 21, 2023

emyl3 commented Aug 21, 2023

emyl3 commented Aug 21, 2023 •

edited

Loading

Add unarchive patient support admin page #6299

Add unarchive patient support admin page #6299

Conversation

emyl3 commented Aug 9, 2023 • edited Loading

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

Additional Information

Testing

Screenshots / Demos

emyl3 Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

emyl3 Aug 10, 2023

Choose a reason for hiding this comment

emyl3 Aug 10, 2023

Choose a reason for hiding this comment

BobanL left a comment

Choose a reason for hiding this comment

johanna-skylight Aug 11, 2023

Choose a reason for hiding this comment

emyl3 Aug 11, 2023

Choose a reason for hiding this comment

emyl3 commented Aug 11, 2023

sonarqubecloud bot commented Aug 18, 2023

emyl3 commented Aug 18, 2023

fzhao99 commented Aug 21, 2023

johanna-skylight commented Aug 21, 2023

emyl3 commented Aug 21, 2023

emyl3 commented Aug 21, 2023 • edited Loading

emyl3 commented Aug 9, 2023 •

edited

Loading

emyl3 Aug 10, 2023 •

edited

Loading

emyl3 commented Aug 21, 2023 •

edited

Loading