-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Organization a11y fixes #5870
Manage Organization a11y fixes #5870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Thanks!
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as expected for me! Thank you for advocating for and modeling the use of the react-hook-form library!! :D
FRONTEND PULL REQUEST
Related Issue
Changes Proposed
Additional Information
Looking at the code it seems that an error message was already coded for the org name field but for some reason the logic to display was not working. I just migrated the form to react hook forms that takes care of validation, error display and focus.
I needed to add code to pass the error of the mutation to the form so it properly handles the isDirty checks.
Testing (code available in dev 4)
Go to settings page -> manage org tab
Try to submit the form with empty values.
Make updates to the form and verify that if there is no change in the form values the save button disables (isDirty check).
Screenshots / Demos