Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Organization a11y fixes #5870

Merged
merged 7 commits into from
Jun 1, 2023

Conversation

johanna-skylight
Copy link
Contributor

@johanna-skylight johanna-skylight commented May 24, 2023

FRONTEND PULL REQUEST

Related Issue

Changes Proposed

  • Migrate the form to use react hook forms
  • Add unit testing

Additional Information

Looking at the code it seems that an error message was already coded for the org name field but for some reason the logic to display was not working. I just migrated the form to react hook forms that takes care of validation, error display and focus.

I needed to add code to pass the error of the mutation to the form so it properly handles the isDirty checks.

Testing (code available in dev 4)

Go to settings page -> manage org tab
Try to submit the form with empty values.
Make updates to the form and verify that if there is no change in the form values the save button disables (isDirty check).

Screenshots / Demos

Screenshot 2023-05-31 at 4 49 44 PM

@johanna-skylight johanna-skylight temporarily deployed to Dev4 May 31, 2023 20:34 — with GitHub Actions Inactive
@johanna-skylight johanna-skylight marked this pull request as ready for review May 31, 2023 20:50
BobanL
BobanL previously approved these changes Jun 1, 2023
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Thanks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected for me! Thank you for advocating for and modeling the use of the react-hook-form library!! :D

@johanna-skylight johanna-skylight requested a review from BobanL June 1, 2023 16:46
@johanna-skylight johanna-skylight merged commit 4f79228 into main Jun 1, 2023
@johanna-skylight johanna-skylight deleted the johanna/5814_manage_organization_a11y_fixes branch June 1, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Manage Organization] Form does not use proper element tag and some inputs are missing inline error
3 participants