Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manage Organization] Form does not use proper element tag and some inputs are missing inline error #5814

Closed
johanna-skylight opened this issue May 16, 2023 · 0 comments · Fixed by #5870
Assignees
Labels
Accessibility Issues that affect SR's accessibility Growth & Engagement

Comments

@johanna-skylight
Copy link
Contributor

johanna-skylight commented May 16, 2023

Area or Component

Settings Page -> Manage Organization Tab

Quick Summary

The form to update the organization information is not set with a form tag and the organization name field does not display inline errors (just the toaster)

How to Replicate

Try to submit an empty organization name and verify no inline error displays.
Inspect the DOM and verify the form is currently using a div as a wrapper.

Accessibility Violation

The required field is not identified by any of the following means: its label or form-level instructions or an error message. https://docs.deque.com/issue-help/1.0.0/en/form-error-required-unclear

Action Requested

Swap the div wrapper with a form tag.
Add inline error to the organization name input field.

As a stretch migrate this form to use react-hook-forms

Screenshots (optional)

Screenshot 2023-05-16 at 12 11 39 PM

@johanna-skylight johanna-skylight added Accessibility Issues that affect SR's accessibility Serious labels May 16, 2023
@johanna-skylight johanna-skylight changed the title Manage Organization [Manage Organization] Form does not use proper element tag and some inputs are missing inline error May 16, 2023
@johanna-skylight johanna-skylight self-assigned this May 24, 2023
@mehansen mehansen added this to the "J" Sprint Goals milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues that affect SR's accessibility Growth & Engagement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants