Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix e2e runner #4322

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Attempt to fix e2e runner #4322

merged 1 commit into from
Sep 26, 2022

Conversation

emmastephenson
Copy link
Contributor

@emmastephenson emmastephenson commented Sep 26, 2022 •
edited
Loading

DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Add the suggested solution from ubuntu image team: eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"

Additional Information

  • all e2e runs on PRs are currently failing; this should fix that issue

Testing

  • e2e action passes on this PR

@emmastephenson
add eval linuxbrew command

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1124b41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

georgehager
georgehager approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@georgehager georgehager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Emma!

zdeveloper
zdeveloper approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@zdeveloper zdeveloper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmastephenson emmastephenson merged commit 1f9609c into main Sep 26, 2022
@emmastephenson emmastephenson deleted the emma/fix-brew-e2e branch September 26, 2022 17:20
georgehager pushed a commit that referenced this pull request Sep 27, 2022
@emmastephenson @georgehager
add eval linuxbrew command (#4322)
81cf963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdeveloper zdeveloper

@DanielSass DanielSass

@georgehager georgehager

@rin-skylight rin-skylight

@snesm snesm

@alismx alismx

@BobanL BobanL

@emyl3 emyl3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@emmastephenson @zdeveloper @DanielSass @georgehager @rin-skylight @snesm