Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TLS on Ingress Controller using Cert Manager / Let's Encrypt #7

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

nickclyde
Copy link
Member

@nickclyde nickclyde commented Aug 25, 2023

Resolves https://app.zenhub.com/workspaces/secret-6480bf2ee530095ab41ebbe9/issues/gh/cdcgov/phdi/779

This enables HTTPS on our Application Gateway Ingress Controller. Followed this guide from Azure.

Basically, added a helm release for cert manager, and a custom manifest for a ClusterIssuer resource, along with the Ingress we have set up in this PR in phdi-charts.

Had to use the gavinbunney/kubectl terraform provider instead of the official kubernetes provider because of this issue.

Also made a few cleanup changes on the deployment workflow.

Copy link
Collaborator

@emmastephenson emmastephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for investigating this Nick! Just a couple of questions.

terraform/implementation/main.tf Outdated Show resolved Hide resolved
terraform/implementation/main.tf Outdated Show resolved Hide resolved
Copy link
Collaborator

@emmastephenson emmastephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making those changes!

@nickclyde nickclyde merged commit a4320f7 into main Aug 28, 2023
@nickclyde nickclyde deleted the nickclyde/cert_manager branch August 28, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants