Convert ingress to Helm chart #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickclyde
requested review from
nickbristow,
gordonfarrell and
KennethSkylight
This was referenced Aug 25, 2023
emmastephenson
approved these changes
Aug 25, 2023
| @@ -2,5 +2,5 @@ apiVersion: v2 | |||
| name: alerts-chart | |||
| description: A Helm chart for Kubernetes | |||
| type: application | |||
| version: 0.1.0 | |||
| version: 0.1.6 | |||
There was a problem hiding this comment.
Definitely not needed for this PR, but I wonder if it makes sense to have this version number in a central location for all charts so it can be updated once and read everywhere.
There was a problem hiding this comment.
Yes, I think that's a good idea!
| port: | ||
| number: 8080 | ||
| - path: /alerts/* | ||
| pathType: Prefix | ||
| backend: | ||
| service: | ||
| name: phdi-{env}-alerts-service | ||
| name: alerts-service |
There was a problem hiding this comment.
Also not needed for this PR, but I'm a little curious about the behavior of the ingress controller when not all the services are present. If we're not running record linkage for instance, what happens when traffic is routed to the /record-linkage endpoint?
There was a problem hiding this comment.
Basically, it just throws a 502 Bad Gateway, and will spit out an error in the event logs for the ingress in Azure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the release/env name from the services so that we can reference them without interpolation (they are already inside a cluster with the environment name anyways)
Also attempting to fix the issue with the release workflow.
Also adds the TLS config needed for this PR in phdi-playground