Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix float negatives #14

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Feature/fix float negatives #14

merged 2 commits into from
Mar 6, 2024

Conversation

andyward
Copy link
Collaborator

@andyward andyward commented Mar 6, 2024

Addresses a couple of issues introduced in the 1e-6 and related fixes. Now more closely follow the 1e-6 algorithm

Ready for merge when convenient

andyward added 2 commits March 6, 2024 11:57
Fixed Range regression with Ints from related commits #13
This incorporates a relative and fixed component to the bounds calculations, and removes need for Rounding to meet standard  test cases & better handles small quantities
@CBenghi
Copy link
Owner

CBenghi commented Mar 6, 2024

Hi @andyward,
Just a reminder that you have collaboration rights on this repository.
When you are comfortable with any changes, feel free to push instead of PR.
Best,
Claudio

@CBenghi CBenghi merged commit 5b667d0 into main Mar 6, 2024
1 check passed
@andyward
Copy link
Collaborator Author

andyward commented Mar 6, 2024

Thanks - only did that as I thought only you could trigger a Nuget publish - but also as I don't want to change XIDS under you if you're doing 0.97 work.
Think I'm done now. I'll push and merge if there's anything else simple.

@andyward andyward deleted the feature/fix-float-negatives branch March 26, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants