Various fixes on ValueConstraint comparison & 1e-6 support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use BaseType was undefined. Renamed TypeNames parsing functions to BETTER indicate their intent/behaviour (left forwarding Obsolete markers) on public interfaces Also fixed 'candidate' typo
Case insensitive ExactConstraint comparisons now ignore accents
Supports Float/Double equality checks only. TODO: Range checking
Only takes effect when using Inclusive ranges. Likely needs review with wider IDS community
… issues in other locales. E.g. 356.789 in italian might be interpretted as 356 thousand-odd, not 356 point 789
Main one being -ve Reals! Better handles extremes.
|
Hi @andyward, |
|
Yes, all done so merge when you can.
Thanks
…On Tue, 5 Mar 2024, 19:53 Claudio Benghi, ***@***.***> wrote:
Hi @andyward <https://github.com/andyward>,
are you still working on this or should I merge?
—
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHBQM7TXWRDFHAT54LMAH3YWYPDFAVCNFSM6AAAAABEHL6LJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZGUZDEMRZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
andyward
added a commit
that referenced
this pull request
Mar 6, 2024
Fixed Range regression with Ints from related commits #13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExactConstraintthe(int)42 == (long)42would fail despite obvious implicit casting available if types were known.BaseType is often undefined. E.g. Attributes don't have a
datatypein the XSD in the same way Psets canignoreCase = true. E.g. "à rénover"=="A Renover"ignoreCase is clearly an extension to the standard, but this feels like a useful addition.
This is based on the algorithm at Testcase "[PASS] Floating point numbers are compared with a 1e-6 tolerance 1-4/4" buildingSMART/IDS#78 (comment)
This last one may need some discussion with other implementors as it introduces some subtleties, such as
42.00001 <= 42 : Constraint Satisfied - despite being > 42
42.00001 > 42 : Constraint Satisfied - as expected