Generalize the dotnet wrapper a bit #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j3parker
force-pushed
the
dotnet-wrapper-generalize
branch
from
5579d3f to
3ad623a
Compare
|
Er, had this sitting around on a branch but I forgot to tidy some stuff up. |
j3parker
force-pushed
the
dotnet-wrapper-generalize
branch
4 times, most recently
from
1200f1c to
8840f29
Compare
|
Ok. |
|
Improvements for future PRs:
|
omsmith
previously approved these changes
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
force-pushed
the
dotnet-wrapper-generalize
branch
from
8840f29 to
a3564d6
Compare
omsmith
reviewed
Mar 7, 2020
| dotnet_argv[0] = const_cast<char*>("dotnet"); | ||
|
|
||
| // Make sure to hold a reference to these std::string. | ||
| auto argv1 = runfiles->Rlocation(kArgv1); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csharp_binaryneeds to become a rule which emits acc_binarythatinvokes
dotnet <foo>, where<foo>is the actual dll that wecompile, to solve #71. Eventually
<foo>will become a wrapper C# exethat tweaks assembly loading to solve #9. So all of this requires the
wrapper to provide a default
argv[1].For stuff like
dotnet vstest(#51) we will haveargv[1]bevstest, so wealso need support for baking in
argv[2].