Add a generic csharp_test built on top of vstest #51
Labels
Milestone
Comments
j3parker
added
enhancement
Merged
This was referenced Oct 1, 2019
j3parker
added a commit
to j3parker/rules_csharp
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
added a commit
to j3parker/rules_csharp
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
added a commit
to j3parker/rules_csharp
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
added a commit
to j3parker/rules_csharp
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
added a commit
to j3parker/rules_csharp
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
added a commit
to j3parker/rules_csharp
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
added a commit
to j3parker/rules_csharp
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve Brightspace#71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve Brightspace#9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (Brightspace#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
j3parker
added a commit
that referenced
this issue
Mar 7, 2020
csharp_binary needs to become a rule which emits a cc_binary that invokes "dotnet <foo>", where "<foo>" is the actual *.dll that we compile, to solve #71. Eventually <foo> will become a wrapper C# exe that tweaks assembly loading to solve #9. So all of this requires the wrapper to provide a default argv[1]. For stuff like dotnet vstest (#51) we will have argv[1] = vstest, so we also need support for baking in argv[2].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now we have
csharp_nunit_test. There is some common infrastructure these days for test frameworks. dotnet vstest is how most people experience it, and I believe the underlying stuff is avaialble in the Microsoft.TestPlatform package.Presumably we could build a generic
csharp_testrule on top of this.csharp_nunit_testcould become a light macro on top of that (adding a reference to nunit.framework) or go away. In either case we'd stop using the NUnitLite runner in favour of vstest.The text was updated successfully, but these errors were encountered: