Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-27]: MM-61599: Remove tabIndex from non-interactive elements #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MA-27]: MM-61599: Remove tabIndex from non-interactive elements #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion webapp/channels/src/components/post/post_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,6 @@ const PostComponent = (props: Props): JSX.Element => {
ref={postRef}
id={getTestId()}
data-testid={postAriaLabelDivTestId}
tabIndex={0}
post={post}
className={getClassName()}
onClick={handlePostClick}
Expand Down
1 change: 0 additions & 1 deletion ...p/channels/src/components/post_edit_history/__snapshots__/post_edit_history.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ exports[`components/post_edit_history should match snapshot 1`] = `
class="post-message__text"
dir="auto"
id="rhsPostMessageText_post_id"
tabindex="0"
>
<p>
post message
Expand Down
5 changes: 0 additions & 5 deletions .../src/components/post_view/post_message_view/__snapshots__/post_message_view.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ exports[`components/post_view/PostAttachment should match snapshot 1`] = `
dir="auto"
id="postMessageText_post_id"
onClick={[Function]}
tabIndex={0}
>
<Connect(PostMarkdown)
imageProps={
Expand Down Expand Up @@ -47,7 +46,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on Show Less
dir="auto"
id="postMessageText_post_id"
onClick={[Function]}
tabIndex={0}
>
<Connect(PostMarkdown)
imageProps={
Expand Down Expand Up @@ -84,7 +82,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on Show More
dir="auto"
id="postMessageText_post_id"
onClick={[Function]}
tabIndex={0}
>
<Connect(PostMarkdown)
imageProps={
Expand Down Expand Up @@ -139,7 +136,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on edited po
dir="auto"
id="postMessageText_post_id"
onClick={[Function]}
tabIndex={0}
>
<Connect(PostMarkdown)
imageProps={
Expand Down Expand Up @@ -177,7 +173,6 @@ exports[`components/post_view/PostAttachment should match snapshot, on ephemeral
dir="auto"
id="postMessageText_post_id"
onClick={[Function]}
tabIndex={0}
>
<Connect(PostMarkdown)
imageProps={
Expand Down
1 change: 0 additions & 1 deletion webapp/channels/src/components/post_view/post_message_view/post_message_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ export default class PostMessageView extends React.PureComponent<Props, State> {
maxHeight={maxHeight}
>
<div
tabIndex={0}
id={id}
className='post-message__text'
dir='auto'
Expand Down
1 change: 0 additions & 1 deletion webapp/channels/src/plugins/test/__snapshots__/post_type.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ exports[`plugins/PostMessageView should match snapshot with no extended post typ
dir="auto"
id="postMessageText_post_id"
onClick={[Function]}
tabIndex={0}
>
<Connect(PostMarkdown)
imageProps={
Expand Down
2 changes: 1 addition & 1 deletion webapp/platform/components/src/generic_modal/__snapshots__/generic_modal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ exports[`GenericModal should match snapshot for base case 1`] = `
aria-hidden="true"
/>
<div
role="dialog"
role="none"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change to none?

>
<div
class="fade modal-backdrop in"
Expand Down
Loading