[MA-27]: MM-61599: Remove tabIndex from non-interactive elements #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaurabhSharma-884
force-pushed
the
ma_27/issue_mm_61599
branch
from
0e20ba4 to
281be0e
Compare
SaurabhSharma-884
requested review from
ayush-chauhan233
and removed request for
thisisankur0
| @@ -11,7 +11,7 @@ exports[`GenericModal should match snapshot for base case 1`] = ` | |||
| aria-hidden="true" | |||
| /> | |||
| <div | |||
| role="dialog" | |||
| role="none" | |||
There was a problem hiding this comment.
Why did this change to none?
ayush-chauhan233
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR ensures focus order of interactive elements on the page is logical and focus is not moved to non-interactive elements of the page.
Steps to reproduce
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-61599
Screenshots
Screencast.from.2024-12-16.18-04-35.webm
Release Note