Lighting tweaks #25
Merged
Lighting tweaks #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamBoots
reviewed
Jun 5, 2024
SamBoots
approved these changes
Jun 8, 2024
There was a problem hiding this comment.
I may have missed some stuff but I think this is better.
If people notice that the lighting is a bit overbright and mention this then we should try to revert it. But from what I know people mainly dislike the darkness in certain areas. This PR fixes it.
Accepted.
Contingencyy
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit subjective. There are certain areas of the game that look way too dark IMO. This was due to the textures that are used as primary light sources in these areas are not marked as lights in the code. The main culprit being metl126. It is used as a primary light source in several places. Most notably the big room at the beginning of level 2.
Rebirth:
Raytraced v1.1
Raytraced v1.1 with metl126 emissive increased (blotchy looking)
This PR with metl126 marked as a light
I also added additional lights for a series of lights on the metl materials:
Before
After
Before
After
These lights are on a base material and required updating RT_ExtractLightsFromSide to also look for lights on base materials as well as overlay. It didn't add any noticeable increase in level load time.
I also took the opportunity to tone down a few of the other lights where the texture itself is small but the light was just as bright as the others, it just looked a bit overbright in a few areas (this one is especially subjective), willing to remove this. The other changes are more important I think.