fix automap aspect ratio #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g3_start_frame (used by automap among others) expects grd_curscreen->sc_aspect to be the pixel aspect ratio (i.e., 1_0f in a mode with square pixels) and not the screen aspect ratio
SamBoots
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g3_start_frame (used by automap among others) expects grd_curscreen->sc_aspect to be the pixel aspect ratio (i.e., 1_0f in a mode with square pixels) and not the screen aspect ratio
otherwise on a 16:9 screen automap shapes end up squished horizontally by a factor of 9/16
this change makes the sc_aspect setup code match what is done in other source ports (and also matches d1\arch\sdl\gr.c)