Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring 2023 Semester Pull Request #523

Merged
merged 250 commits into from
May 5, 2023
Merged

Spring 2023 Semester Pull Request #523

merged 250 commits into from
May 5, 2023

Conversation

charlestian23
Copy link
Collaborator

@charlestian23 charlestian23 commented Apr 7, 2023

Description

A pull request containing the work from the Spring 2023 semester. Majority of the work done this semester was bug fixes.

  • A couple new UI features were added, such as dark mode and color blindness support
  • "Basic Rules" were also renamed to "Direct Rules" at the suggestion of Professor Bram
  • Some unit tests were written for select puzzles
  • Updated documentation for puzzles and the puzzle editor tutorial

Note: Short Truth Table puzzle editor support will be delayed to the next pull request due to issues with getting the files to save properly

19690ao and others added 30 commits January 27, 2023 14:53
Changed UI texts, file and function names that have "Basic Rules" in it to "Direct Rules."
…term "Direct Rules" instead of "Basic Rules"
Fixed: Rename "Basic Rules" to "Direct Rules"
[FIXED BUG] <Editing a Puzzle's that don't have an edit funciton>
Acewvrs and others added 26 commits April 18, 2023 16:43
* Update NurikabeCell.java

Changed setType() to use element IDs rather than element names

* Renamed instances of Basic Rule to Direct Rule

* Renamed Basic Rule to Direct Rule for Tree Tent tests

* Renamed directories from Basic Rule to Direct Rules

* Renamed Direct Rules to Basic Rules in Light Up tests

* Added back BlockInVerticalPath
* Update Config.java

* Update GameBoardFacade.java

* Update ICommand.java

* Update ICommand.java

* Update ICommand.java

* Update Puzzle.java

* Update GameBoardFacade.java

* Update Config.java

* Update GameBoardFacade.java

* Update Puzzle.java

* Update Puzzle.java

* Update Puzzle.java

* Update SkyscrapersBoard.java

* Update SkyscrapersBoard.java

* Update SkyscrapersBoard.java

* Update SkyscrapersBoard.java

* Update SkyscrapersBoard.java

* Update SkyscrapersBoard.java

* Update SkyscrapersBoard.java

* Update SkyscrapersCellFactory.java

* Update PuzzleExporter.java

* Update BattleshipCellFactory.java

* Update PuzzleExporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update PuzzleImporter.java

* Update BattleshipImporter.java

* Created descriptions for param node and exception InvalidFileException

* Update BattleshipType.java

* Update BattleshipType.java

* Update BoardView.java

* Update GridBoardView.java

* Update FillapixCellFactory.java

* Update FillapixImporter.java

* Update FillapixImporter.java

* Update HeyawakeFactory.java

* Update HeyawakeImporter.java

* Update BattleshipImporter.java

* Update HeyawakeImporter.java

* Update AutoCaseRuleCommand.java

* Update AutoCaseRuleCommand.java

* Update ValidateCaseRuleCommand.java

* Update LightUpCellFactory.java

* Update LightUpImporter.java

* Update MasyuCellFactory.java

* Update MasyuImporter.java

* Update NurikabeCellFactory.java

* Update NurikabeImporter.java

* Update RulePanel.java

* Update RulePanel.java

* Update RulePanel.java

* Update RulePanel.java

* Update RulePanel.java

* Update ShortTruthTableCellFactory.java

* Update ShortTruthTableCellType.java

* Update ShortTruthTableCellType.java

* Update ShortTruthTableCellType.java

* Update SkyscrapersBoard.java

* Update SkyscrapersImporter.java

* Update SkyscrapersImporter.java

* Update SudokuCell.java

* Update SudokuCellFactory.java

* Update SudokuImporter.java

* Update SudokuImporter.java

* Update Tree.java

* Update TreeTentCellFactory.java

* Update TreeTentImporter.java

* Update TreeToolbarPanel.java

* Update LegupUI.java

* Update WrapLayout.java

* Update LegupUtils.java

* Update ValidateContradictionRuleCommand.java

---------

Co-authored-by: Ivan Ho <[email protected]>
Co-authored-by: Charles Tian <[email protected]>
* Reset button attempt 1

* Reset button attempt works

* checkstyle fix

* checkstyle fix

* checkstyle fix

---------

Co-authored-by: Charles Tian <[email protected]>
Co-authored-by: Ivan Ho <[email protected]>
Update NurikabeCell.java to use .getElementID instead of .getElementName
Changed NurikabeCell.java from if/else to switch statements
Allowed Case rules for Light Up puzzles to Have Only One Option
@charlestian23 charlestian23 marked this pull request as ready for review May 5, 2023 01:19
@charlestian23 charlestian23 merged commit f81475f into master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semester push For the final master push of the working semester
Projects
None yet
Development

Successfully merging this pull request may close these issues.