Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <Editing a Puzzle's that don't have an edit funciton> #331

Closed
anthonyfabius opened this issue Oct 11, 2022 · 2 comments
Closed

[BUG] <Editing a Puzzle's that don't have an edit funciton> #331

anthonyfabius opened this issue Oct 11, 2022 · 2 comments
Assignees
Labels
bug Something isn't working puzzle editor Related to creating or editing puzzle files

Comments

@anthonyfabius
Copy link
Collaborator

Description

Currently with the edit puzzle button you are able to open puzzle files that don't have an edit feature. This leaves you with a puzzle on the screen but no elements or no way to interact with it. Thus making it useless

Steps to Reproduce

  1. Click on the edit puzzle button to open the file directory
  2. Open any puzzle under the ones that don't have an edit feature
    1. Fillipix
    2. Masyu
    3. Short Truth Table
    4. Skyscrapers
    5. Sudoku
  3. See bug (No selectable elements)

Expected Behavior

Puzzles that have no elements should give an error and return you back to the file explorer so that you can choose a puzzle that lets you edit it.

Screenshots

Picture of elements for a puzzle that has an editor (Lightup)
image

Picture of elements for a puzzle that does not have an editor (Masyu)
image
image

Puzzle Files

No response

Additional Context

The thing that makes this bug annoying is most of the puzzles don't have file name extensions. Unless someone wants to implement this to make it easier to differentiate the different game files that would be sick but that come with its own set of problems.

@anthonyfabius anthonyfabius added the bug Something isn't working label Oct 11, 2022
@19690ao 19690ao self-assigned this Oct 18, 2022
@charlestian23 charlestian23 added the puzzle editor Related to creating or editing puzzle files label Dec 30, 2022
@charlestian23
Copy link
Collaborator

I think the puzzle name is coded into the puzzle file. Here's an example of a Masyu puzzle file:
image

We could potentially just do a check to see if the file is for a game that isn't implemented yet.

@anthonyfabius
Copy link
Collaborator Author

I didn't even know that. That definitely helps solve the problem.

@19690ao 19690ao removed their assignment Jan 27, 2023
@DavidColetta DavidColetta self-assigned this Feb 3, 2023
DavidColetta added a commit to DavidColetta/Legup that referenced this issue Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working puzzle editor Related to creating or editing puzzle files
Projects
None yet
Development

No branches or pull requests

4 participants