Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved text below icon for search panel #463

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Moved text below icon for search panel #463

merged 1 commit into from
Feb 17, 2023

Conversation

RyancRiv
Copy link
Collaborator

Description

When searching for rules in the search panel, the buttons sizes used to not be regulated and the text was on the side making the panel look disorganized. This was because in the searchForRule function, when buttons were created from the found rules there was no changes to the preferred size of the button. I added this code to make the preferred size 150 x 150 and I also moved the text to be at the bottom of the button and centered, like in the other panels.

In the searchForRule function, when similar rules were found to the search result and a new button was created; I added code to change the preferred size using setPreferredSize, and I changed the positioning of the text using setHorizontalTextPosition and setVerticalTextPosition.

Closes #432

Type of change

  • [ -] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • [ -] I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • [ -] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Made buttons same size and moved text to bottom
Copy link
Collaborator

@charlestian23 charlestian23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good

@charlestian23 charlestian23 merged commit 7e98aad into Bram-Hub:dev Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants