Add initial global search setup #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komediruzecki
force-pushed
the
feature/improve-global-search
branch
from
9ef263b to
8739912
Compare
Rokt33r
requested changes
Dec 6, 2020
There was a problem hiding this comment.
Some characters, (, break searching.
Also, this PR can be separated. If you don't mind could you split the PR? Otherwise, we have to wait till everything is ready.
So I think we can split like this:
- Show preview of searched notes
- Improve search function
- Navigate to a specific line from URL.
Rokt33r
added
the
awaiting changes 🖊️
Komediruzecki
force-pushed
the
feature/improve-global-search
branch
2 times, most recently
from
01a2bf7 to
837a973
Compare
Komediruzecki
force-pushed
the
feature/improve-global-search
branch
from
837a973 to
02b0858
Compare
Komediruzecki
removed
the
awaiting changes 🖊️
Komediruzecki
force-pushed
the
feature/improve-global-search
branch
from
9a160d6 to
72dfd99
Compare
Add search functionality and result data structures Add preview of found items, highlighted style, the rows of found items Add note preview Add selection of items in search Add text highlight in editor preview Add editor preview focus Add editor preview while clicking on found item Add better ID management and state update fix Add some stability updates (max searched content, max result line length) Add double click on search item to lead to focused item in editor Add focusLine number for editor to route params Add better colors across themes for search Fix multiline search Add all previous features in multiline search Focus at correct item on multiple items (local column) Focus at correct editor position (line and column) via route hash
Add auto focus (scrollIntoView) if user selects the item below editor preview pane
Rokt33r
force-pushed
the
feature/improve-global-search
branch
from
4a38d57 to
24e68f3
Compare
- title overflow in preview - show placeholder when title is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tag colors setup (#219, #629, #681, #570):
General functionality:
Currently searches throught the content only (with some restrictions).
Setup for title/tags is commented out and can be added (title/tags highlighted etc) easily
When user clicks on any found item inside one note, that item is focused in preview (as seen in images below)
When user double clicks on an item in found items list of note, focused navigation takes place (navigates to note and focus the selected line in editor), the search dialog is closed
Currently the binding is still CTRL+P for searching globally, but we could easily replace this with CTRL+SHIFT+F for global and CTRL+F for local search (already set).
Restrictions:
First 10k lines of each note searched
Todo:
Few search examples:
Popup on hover when line is too long so it won't show the whole line
Test: